Created a metadata rule to replace composed-jar attribute by jar. #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderBartash
force-pushed
the
issue-1802
branch
from
82aedc1 to
0a7e6dc
Compare
| // } | ||
| // } | ||
| // } | ||
| //} |
There was a problem hiding this comment.
I created two versions, feel free to use whatever you like.
AlexanderBartash
force-pushed
the
issue-1802
branch
from
0a7e6dc to
0ebf24f
Compare
|
| } | ||
| } | ||
| } | ||
|
|
||
| implementation( | ||
| "com.redhat.devtools.intellij:intellij-common:${intellijCommonVersion}", |
There was a problem hiding this comment.
I just noticed another api which might work you can try:
implementation("com.redhat.devtools.intellij:intellij-common:${intellijCommonVersion}") {
attributes {
attribute(LibraryElements.LIBRARY_ELEMENTS_ATTRIBUTE, objects.named("composed-jar"))
}
}
There was a problem hiding this comment.
tested it in a different PR where I needed this: df398b4 Works super nicely. I'll add you as co-author to my PR. Thanks!
|
@AlexanderBartash whoo thanks for the PR ! |
|
Using this in df398b4. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.